Add docker-tests coverage of metrics export#5030
Open
tammy-baylis-swi wants to merge 14 commits into
Open
Conversation
anuraaga
reviewed
Apr 2, 2026
11 tasks
herin049
approved these changes
Apr 4, 2026
Co-authored-by: Lukas Hering <40302054+herin049@users.noreply.github.com>
Co-authored-by: Lukas Hering <40302054+herin049@users.noreply.github.com>
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
Contributor
|
Should we still contribute to docker tests while the discussion for system wide docker image is still going on? |
Contributor
The discussion was about using a system wide docker binary, so any improvements in docker tests is fine |
xrmx
reviewed
May 13, 2026
| ([#5036](https://github.com/open-telemetry/opentelemetry-python/pull/5036)) | ||
| - `opentelemetry-sdk`: Implement experimental Logger configurator | ||
| ([#4980](https://github.com/open-telemetry/opentelemetry-python/pull/4980)) | ||
| - `opentelemetry-exporter-otlp-proto-grpc`, `opentelemetry-exporter-otlp-proto-http`: add docker-tests coverage of metrics export |
Contributor
There was a problem hiding this comment.
This needs to be moved to a changelog fragment
xrmx
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds docker-tests coverage of metrics export: general test (did not exist), test focused on
max_export_batch_sizewithout mocks, for both gRPC and HTTP. Updates the docker-compose for otelcollector version used.Extending the MetricExporter classes to count batches is hopefully reasonable. Trying to capture otelcollector
debugoutput then parse exact metrics values for "batches forwarded" is too much, imo.Fixes #5031
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
opentelemetry-docker-testsDoes This PR Require a Contrib Repo Change?
Checklist: